gh-100239: Specialize binary operations using BINARY_OP_EXTEND#128956
Open
eendebakpt wants to merge 9 commits intopython:mainfrom
Open
gh-100239: Specialize binary operations using BINARY_OP_EXTEND#128956eendebakpt wants to merge 9 commits intopython:mainfrom
eendebakpt wants to merge 9 commits intopython:mainfrom
Conversation
03b3922 to
51d1b11
Compare
# Conflicts: # Lib/test/test_capi/test_opt.py # Python/specialize.c
Member
|
This looks good overall, but I've not done a detailed review. I have a couple of general concerns about the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BINARY_OP_EXTENDBINARY_OP_EXTENDin tier 2. This allows the jit to perform better optimizations._GUARD_BINARY_OP_EXTENDif type information is known.BINARY_OPincreases from 70% to 90%.Benchmark are performance neutral (in the +- 1% range) is seems.
Benchmark script